Merge main into releases/v4#3252
Merged
henrymercer merged 55 commits intoreleases/v4from Oct 30, 2025
Merged
Conversation
Mergeback v4.31.0 refs/heads/releases/v4 into main
Ensure uniqueness of overlay-base database cache keys
…utation Move diff-range computation into utils
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm-minor group with 4 updates: [@octokit/types](https://github.com/octokit/types.ts), [@types/archiver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/archiver), [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@octokit/types` from 15.0.0 to 15.0.1 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](octokit/types.ts@v15.0.0...v15.0.1) Updates `@types/archiver` from 6.0.3 to 6.0.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/archiver) Updates `@typescript-eslint/eslint-plugin` from 8.46.1 to 8.46.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.46.2/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.46.1 to 8.46.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.46.2/packages/parser) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-version: 15.0.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: "@types/archiver" dependency-version: 6.0.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.46.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: "@typescript-eslint/parser" dependency-version: 8.46.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@actions/artifact](https://github.com/actions/toolkit/tree/HEAD/packages/artifact) from 2.3.1 to 4.0.0. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/@actions/cache@4.0.0/packages/artifact) --- updated-dependencies: - dependency-name: "@actions/artifact" dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the actions-minor group with 1 update in the /.github/workflows directory: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.265.0 to 1.267.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@ab177d4...d5126b9) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.267.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This was introduced in Node.js 18
Support skipping workflow validation
This allows us to remove the `console-log-level` dependency.
…artifact-4.0.0 Bump @actions/artifact from 2.3.1 to 4.0.0
…thub/workflows/actions/upload-artifact-5 Bump actions/upload-artifact from 4 to 5 in /.github/workflows
…r-75b724c14c Bump the npm-minor group with 4 updates
…thub/workflows/actions-minor-b11285d543 Bump ruby/setup-ruby from 1.265.0 to 1.267.0 in /.github/workflows in the actions-minor group across 1 directory
Check disk usage using Node.js API
Use Node `fs` APIs instead of `del`
Use Actions logger in API client
Turn enablement errors into configuration errors
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
Remove `add-snippets` input
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges changes from the main branch into the releases/v4 branch for version 4.31.1 of the CodeQL Action. The release focuses on removing deprecated functionality, upgrading dependencies, and improving code maintainability.
Key changes include:
- Removal of the deprecated
add-snippetsinput from the analyze action - Replacement of external dependencies (
del,check-disk-space,console-log-level) with native Node.js implementations - Introduction of a new
checkWorkflowfunction to encapsulate workflow validation logic - Updates to dependency versions in package.json and workflow files
Reviewed Changes
Copilot reviewed 41 out of 54 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Documents removal of add-snippets input in version 4.31.1 |
| package.json | Updates version to 4.31.1 and upgrades dependencies |
| analyze/action.yml | Marks add-snippets input as removed |
| src/workflow.ts | Introduces checkWorkflow wrapper function and makes validateWorkflow internal |
| src/workflow.test.ts | Adds comprehensive tests for checkWorkflow function |
| src/util.ts | Replaces del and check-disk-space with native fs.promises APIs |
| src/util.test.ts | Removes tests for deleted getAddSnippetsFlag function and adds disk usage test |
| src/overlay-database-utils.ts | Adds run ID and attempt ID to cache keys; exports previously internal functions |
| src/overlay-database-utils.test.ts | Adds test to verify cache key stability |
| src/diff-informed-analysis-utils.ts | Moves diff range calculation functions from analyze.ts |
| src/diff-informed-analysis-utils.test.ts | Adds tests for diff range calculation |
| src/analyze.ts | Removes diff range calculation logic (moved to diff-informed-analysis-utils.ts) and add-snippets parameter |
| src/analyze.test.ts | Removes diff range tests (moved to diff-informed-analysis-utils.test.ts) |
| src/analyze-action.ts | Adds warning for deprecated add-snippets input and removes its usage |
| src/codeql.ts | Removes addSnippetsFlag parameter from databaseRunQueries |
| src/api-client.ts | Replaces console-log-level with direct core function references and adds enablement error handling |
| src/logging.ts | Returns explicit object instead of direct core reference |
| src/init-action.ts | Uses new checkWorkflow function |
| Multiple workflow files | Updates upload-artifact and setup-ruby action versions |
mbg
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging 777daa0 into
releases/v4.Conductor for this PR is @mbg.
Contains the following pull requests:
add-snippetsinput #3239 (@mbg)fsAPIs instead ofdel#3250 (@henrymercer)Please do the following:
releases/v4branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.